fix: image not found in README.md while mdbook build #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 1ca2a86, all assets embed to top directory in book and could not be found on reading. Another issue is not handle README.md path correctly while applying mdbook link preprocessor. This commit fixes above issues and update an integration test to ensure assets is embedded to expected path. svg image is from https://commons.wikimedia.org/wiki/File:Epub_logo.svg
dieterplex
force-pushed
the
img-in-readme
branch
from
fc1e086 to
7030f68
Compare
dieterplex
commented
Jul 23, 2024
blandger
reviewed
Nov 30, 2024
Comment on lines
-87
to
-89
| let filename = if cfg!(target_os = "windows") { | ||
| binding.as_os_str().to_os_string() | ||
| .into_string().expect("Error getting filename for Local Asset").replace('\\', "/") |
There was a problem hiding this comment.
I'm not sure if that is good to remove that code. I remember there were problems on Win, so I added that piece of code. I doubt that is good.
There was a problem hiding this comment.
Any exact cases could be added to testcases?
Things like https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file?
There was a problem hiding this comment.
That code is related to problem of building epub book on Windows platform. We should change window's based '\' to path like '/' as that should be by epub specification.
See also
#[test] fn test_normalize_path_win() {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #115